🐛 Fix nested object filtering in JSONB WHERE clauses#71
Merged
Conversation
Fixed incorrect SQL generation for nested object filters in GraphQL WHERE clauses. The bug caused filters on nested objects to access fields at the root level instead of the correct nested path in JSONB columns. Changes: - Modified where_generator.py to pass parent_path through the to_sql() chain - Added _build_nested_path() helper for cleaner path construction - Enhanced tests to validate correct JSONB path generation - Added deep nesting test coverage (3+ levels) Before: WHERE (data ->> 'id') = '...' # Incorrect root-level access After: WHERE (data -> 'machine' ->> 'id') = '...' # Correct nested path Fixes the issue reported in fraiseql_nested_filter_bug_report.md 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data -> 'machine' ->> 'id'instead of accessing fields at root levelProblem
When using nested object filters in GraphQL WHERE clauses with JSONB-backed tables, FraiseQL was generating incorrect SQL that didn't properly handle the nested object path. This caused filters to fail silently and return unfiltered results.
Before (incorrect):
After (correct):
Changes
where_generator.pyto passparent_paththrough theto_sql()method chain_build_nested_path()helper function for cleaner path constructionDynamicTypeProtocol to include the new parameterTest plan
🤖 Generated with Claude Code